Messages in this thread | | | Date | Mon, 5 Jun 2023 06:53:36 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH v2 01/13] fs: export mnt_idmap_get/mnt_idmap_put |
| |
On Fri, Jun 02, 2023 at 02:40:27PM +0200, Christian Brauner wrote: > On Wed, May 24, 2023 at 05:33:03PM +0200, Alexander Mikhalitsyn wrote: > > These helpers are required to support idmapped mounts in the Cephfs. > > > > Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com> > > --- > > It's fine by me to export them. The explicit contract is that _nothing > and absolutely nothing_ outside of core VFS code can directly peak into > struct mnt_idmap internals. That's the only invariant we care about.o
It would be good if we could keep all these somewhat internal exports as EXPORT_SYMBOL_GPL, though.
| |