Messages in this thread | | | Date | Mon, 5 Jun 2023 00:29:55 -0700 (PDT) | From | Ilkka Koskinen <> | Subject | Re: [PATCH 1/4] perf/arm_cspmu: Fix event attribute type |
| |
On Thu, 1 Jun 2023, Robin Murphy wrote: > ARM_CSPMU_EVENT_ATTR() defines a struct perf_pmu_events_attr, so > arm_cspmu_sysfs_event_show() should not be interpreting it as struct > dev_ext_attribute. > > Fixes: e37dfd65731d ("perf: arm_cspmu: Add support for ARM CoreSight PMU driver") > Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Reviewed-and-tested-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>
> --- > drivers/perf/arm_cspmu/arm_cspmu.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/perf/arm_cspmu/arm_cspmu.c b/drivers/perf/arm_cspmu/arm_cspmu.c > index a3f1c410b417..72dc7a9e1ca8 100644 > --- a/drivers/perf/arm_cspmu/arm_cspmu.c > +++ b/drivers/perf/arm_cspmu/arm_cspmu.c > @@ -189,10 +189,10 @@ static inline bool use_64b_counter_reg(const struct arm_cspmu *cspmu) > ssize_t arm_cspmu_sysfs_event_show(struct device *dev, > struct device_attribute *attr, char *buf) > { > - struct dev_ext_attribute *eattr = > - container_of(attr, struct dev_ext_attribute, attr); > - return sysfs_emit(buf, "event=0x%llx\n", > - (unsigned long long)eattr->var); > + struct perf_pmu_events_attr *pmu_attr; > + > + pmu_attr = container_of(attr, typeof(*pmu_attr), attr); > + return sysfs_emit(buf, "event=0x%llx\n", pmu_attr->id); > } > EXPORT_SYMBOL_GPL(arm_cspmu_sysfs_event_show); > > -- > 2.39.2.101.g768bb238c484.dirty > >
| |