Messages in this thread | | | Date | Mon, 5 Jun 2023 21:12:25 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCHv13 5/9] efi: Add unaccepted memory support |
| |
On Mon, Jun 05, 2023 at 08:33:03PM +0300, Kirill A. Shutemov wrote: > There's nothing to warn about. The range (or part of it) is not > represented in the bitmap because it is not unaccepted.
Sorry but how am I supposed to know that?!
I've read the whole patchset up until now and all text talks like *all* *memory* needs to be accepted and before that has happeend, it is unaccepted.
So how about you explain that explicitly somewhere, perhaps in a comment above accept_memory(), that the unaccepted range is not the whole memory but only, well, what is unaccepted and the rest is implicitly accepted?
And I went and looked at the final result - we error() if we fail accepting.
I guess that's the only action we can do anyway...
> Yes, it was discussed before. Here's context: > > https://lore.kernel.org/all/Ynt8vDY78/YeXO99@zn.tnic
You should try those before you paste them - it says "Not found" because of the '/' in the Message-ID and it needs to be escaped.
This works:
https://lore.kernel.org/all/Ynt8vDY78%2FYeXO99@zn.tnic/
Now I remember.
Thx.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |