lkml.org 
[lkml]   [2023]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/3] iio: adc: Add Allwinner D1/T113s/R329/T507 SoCs GPADC

> > + if (!wait_for_completion_timeout(&info->completion,
> > + msecs_to_jiffies(100))) {
>
> Dunno if it's better to have this parameter to be defined with self-explanatory
> name.

Probably a response to my earlier comment. I'd agree with a good name
but GPADC_TIMEOUT which was the earlier naming is less use than a value
and it's not obvious what that name should be.

A nice datasheet reference would be good to have though.

>
> > + ret = -ETIMEDOUT;
> > + goto err;
> > + }
>
>
> > + if (num_channels > SUN20I_GPADC_MAX_CHANNELS) {
> > + dev_err(dev, "num of channel children out of range");
> > + return -EINVAL;
> > + }
>
> Is it really critical error?

Overflow of registers - so yes. I wondered this on v1 and went digging :)
Now, there are no such devices known, so meh on whether check is useful.

>
> ...

\
 
 \ /
  Last update: 2023-06-04 12:42    [W:0.088 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site