Messages in this thread | | | Date | Fri, 30 Jun 2023 16:49:30 -0500 | From | Bjorn Helgaas <> | Subject | Re: [PATCH V5 1/3] Move and rename error interrupt bits to a common header. |
| |
The subject line needs to contain "PCI: " and the driver name. The subject line also should not end with a period. It looks like some of these interrupt bits are not errors.
Mentioned previously at https://lore.kernel.org/r/ZF6SHJ44s4OqPYj4@bhelgaas
Suggest this instead:
PCI: xilinx-cpm: Move interrupt bit definitions to common header
On Wed, Jun 28, 2023 at 02:58:10PM +0530, Thippeswamy Havalige wrote: > Move and rename error interrupt bit macros to a common header file for > code reusability.
Suggest this:
Rename Xilinx interrupt bit definitions so they are not CPM-specific. Move the definitions to pcie-xilinx-common.h where they can be shared between pcie-xilinx-cpm and the new xilinx-xdma driver.
> Move common linux header files for reusability.
This sentence is redundant and should be removed.
> Signed-off-by: Thippeswamy Havalige <thippeswamy.havalige@amd.com> > Signed-off-by: Bharat Kumar Gogada <bharat.kumar.gogada@amd.com>
Bjorn
| |