Messages in this thread | | | From | Ian Rogers <> | Date | Fri, 30 Jun 2023 11:01:53 -0700 | Subject | Re: [v2 01/13] perf parse-events: Remove unused PE_PMU_EVENT_FAKE token |
| |
On Fri, Jun 30, 2023 at 10:52 AM Markus Elfring <Markus.Elfring@web.de> wrote: > > >> Can the mentioned patch review concern be adjusted with wording alternatives > >> for improved commit messages? > > > > Sorry, checked with a colleague and kernel contributor, > > Interesting … > > > > we don't know what is being requested here, > > Another bit of attention for a known information source: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n94 > > > > "imperative mood" makes no sense, > > How does such an opinion fit to the Linux development documentation? > > > > as such I don't have a fix for what you're requesting. > > I got the impression that further possibilities can be taken better into account > also for improved change descriptions.
Thanks Markus, I appreciate you feel you have a real point here, I'm just not getting it. Perhaps you can write a commit message that fulfils requirements like being in the correct "imperative mood" and I will learn and improve.
Thanks, Ian
> Regards, > Markus
| |