Messages in this thread | | | Date | Fri, 30 Jun 2023 15:39:13 +0300 | From | Heikki Krogerus <> | Subject | Re: [PATCH v2 1/3] usb: typec: Set port->pd before adding device for typec_port |
| |
On Fri, Jun 23, 2023 at 11:10:34PM +0800, Kyle Tso wrote: > When calling device_add in the registration of typec_port, it will do > the NULL check on usb_power_delivery handle in typec_port for the > visibility of the device attributes. It is always NULL because port->pd > is set in typec_port_set_usb_power_delivery which is later than the > device_add call. > > Set port->pd before device_add and only link the device after that. > > Fixes: a7cff92f0635 ("usb: typec: USB Power Delivery helpers for ports and partners") > Cc: stable@vger.kernel.org > Signed-off-by: Kyle Tso <kyletso@google.com>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
thanks,
-- heikki
| |