Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 30 Jun 2023 10:54:34 +0530 | Subject | Re: [PATCH 1/4] pcie: qcom: Fix the macro PARF_SLV_ADDR_SPACE_SIZE_2_3_3 | From | Sricharan Ramabadhran <> |
| |
On 6/24/2023 12:02 PM, Manivannan Sadhasivam wrote: > On Fri, Jun 23, 2023 at 03:04:42PM +0530, Sricharan Ramabadhran wrote: >> PARF_SLV_ADDR_SPACE_SIZE_2_3_3 macro used for IPQ8074 >> pcie slave addr size was initially set to 0x358, but >> was wrongly changed to 0x168 as a part of >> 'PCI: qcom: Sort and group registers and bitfield definitions' >> Fixing it back to right value here. >> >> Without this pcie bring up on IPQ8074 is broken now. >> > > Subject prefix should be: "PCI: qcom: " > >> Fixes: 769e49d87b15 ("PCI: qcom: Sort and group registers and bitfield definitions") > > Fixes tag is referring to a wrong commit. Correct one is: > 39171b33f652 ("PCI: qcom: Remove PCIE20_ prefix from register definitions") >
ok.
>> Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> >> --- >> drivers/pci/controller/dwc/pcie-qcom.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c >> index 4ab30892f6ef..59823beed13f 100644 >> --- a/drivers/pci/controller/dwc/pcie-qcom.c >> +++ b/drivers/pci/controller/dwc/pcie-qcom.c >> @@ -43,7 +43,7 @@ >> #define PARF_PHY_REFCLK 0x4c >> #define PARF_CONFIG_BITS 0x50 >> #define PARF_DBI_BASE_ADDR 0x168 >> -#define PARF_SLV_ADDR_SPACE_SIZE_2_3_3 0x16c /* Register offset specific to IP ver 2.3.3 */ >> +#define PARF_SLV_ADDR_SPACE_SIZE_2_3_3 0x358 /* Register offset specific to IP ver 2.3.3 */ > > You should just remove PARF_SLV_ADDR_SPACE_SIZE_2_3_3 and use > PARF_SLV_ADDR_SPACE_SIZE which already has the value of 0x358. >
ok
Regards, Sricharan
| ![\](/images/icornerr.gif) |