Messages in this thread | | | From | "Zhuo, Qiuxu" <> | Subject | RE: [PATCH] EDAC/i10nm: shift exponent is negative | Date | Fri, 30 Jun 2023 08:31:14 +0000 |
| |
> From: Luck, Tony <tony.luck@intel.com> > Sent: Friday, June 30, 2023 12:12 AM > To: Zhuo, Qiuxu <qiuxu.zhuo@intel.com>; Koba Ko <koba.ko@canonical.com> > Cc: Borislav Petkov <bp@alien8.de>; James Morse <james.morse@arm.com>; > Mauro Carvalho Chehab <mchehab@kernel.org>; Robert Richter > <rric@kernel.org>; linux-edac@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: RE: [PATCH] EDAC/i10nm: shift exponent is negative > > > I don't agree with simply skipping over a DIMM even EDAC doesn't expect > to see it. > > As the EDAC driver can still report errors for this DIMM once there are > errors that occur in this DIMM. > > > > As per Tony's suggestion, could you test your kernel with > CONFIG_EDAC_DEBUG=y and see the result? > > > > @Luck, Tony, Perhaps we may turn the debug print > > > > edac_dbg(2, "bad %s = %d (raw=0x%x)\n", name, val, reg); > > > > to an error-print explicitly > > > > skx_printk(KERN_ERR, "bad %s = %d (raw=0x%x)\n", name, val, reg); > > > > Let the user have the chance to notice there is a DIMM that EDAC doesn't > expect to see. > > We need both. Changing that debug message to a real error message will let > the user know that EDAC doesn't recognize this DIMM (and will provide the > information for you or me to fix the driver). > > But we also need Ko's fix - because it makes no sense to just use that > negative shift and pretend that EDAC knows how to handle this DIMM. >
OK. @Koba Ko, could you make a new patch with Tony's suggestion? Thanks!
-Qiuxu
| |