Messages in this thread | | | Date | Fri, 30 Jun 2023 10:29:01 +0200 | From | Takashi Iwai <> | Subject | Re: [PATCH 1/2] ALSA: hda/realtek: Add quirk for ASUS ROG GX650P |
| |
On Fri, 30 Jun 2023 06:31:05 +0200, Luke D. Jones wrote: > > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -5883,7 +5883,7 @@ static void alc_fixup_headset_mode_alc255_no_hp_mic(struct hda_codec *codec, > struct alc_spec *spec = codec->spec; > spec->parse_flags |= HDA_PINCFG_HEADSET_MIC; > alc255_set_default_jack_type(codec); > - } > + } > else > alc_fixup_headset_mode(codec, fix, action); > }
This change looks irrelevant. Could you drop it? If it needs to be fixed, put in another cleanup patch.
thanks,
Takashi
| |