Messages in this thread | | | Date | Mon, 26 Jun 2023 09:39:01 -0700 | From | Boqun Feng <> | Subject | Re: [RFC PATCH 1/8] rust: kernel: add basic abstractions for device-mapper |
| |
On Mon, Jun 26, 2023 at 11:26:12AM +0800, Qingsong Chen wrote: > On 6/25/23 8:25 PM, Greg KH wrote: > > Shouldn't this be all different commits, and different files? A bio > > shouldn't be defined in the device_mapper.rs file, as that would prevent > > anyone else from accessing it. > > Yes, you're right. Since we noticed that some block layer patches[1] > are under review, we don't put much effort into that. Actually, we > don't want to include all the `bio` implementation in this patchset, > so it just some dummy codes. > > If necessary, a seperate commit could be splited, including things > that do not belong to the device mapper. >
Maybe you can just base on one or all the patches from Andreas' series (and mention the dependency in the cover letter)?
Regards, Boqun
> [1]: https://lore.kernel.org/rust-for-linux/20230503090708.2524310-5-nmi@metaspace.dk/ > > Thanks, > Qingsong Chen
| |