Messages in this thread | | | Date | Mon, 26 Jun 2023 17:37:44 +0100 | From | Mark Brown <> | Subject | Re: [PATCH RFC v4 02/13] regulator: add getter for active monitors |
| |
On Mon, Jun 26, 2023 at 04:43:49PM +0300, Matti Vaittinen wrote: > On 6/20/23 23:02, Benjamin Bara wrote:
> > + * @get_active_protections: Get all enabled monitors of a regulator. OR'ed val > > + * of REGULATOR_MONITOR_*.
> I think it wouldn't hurt to have doc stating in which case populating this > call-back is needed? I haven't read rest of the patches yet but I guess this > callback is going to be used internally by the regulator core and maybe it > is not obvious for driver author that this is needed by core to be able to > support automatic protection handling.
I think this is true for pretty much all callbacks - broadly it's just the case that if the hardware has a feature the best practice is that the driver should implement all relevant operations. [unhandled content-type:application/pgp-signature] | |