Messages in this thread | | | From | Ilya Dryomov <> | Date | Mon, 26 Jun 2023 17:41:03 +0200 | Subject | Re: [PATCH net-next v5 03/16] ceph: Use sendmsg(MSG_SPLICE_PAGES) rather than sendpage |
| |
On Mon, Jun 26, 2023 at 4:00 PM David Howells <dhowells@redhat.com> wrote: > > Ilya Dryomov <idryomov@gmail.com> wrote: > > > Same here... I would suggest that you keep ceph_tcp_sendpage() function > > and make only minimal modifications to avoid regressions. > > This is now committed to net-next.
This needs to be dropped from linux-next because both this and especially the other (net/ceph/messenger_v2.c) patch introduce regressions.
> I can bring ceph_tcp_sendpage() back into > existence or fix it in place for now if you have a preference.
I already mentioned that I would prefer if ceph_tcp_sendpage() was brought back into existence.
> > Note that I'm working on patches to rework the libceph transmission path so > that it isn't dealing with transmitting a single page at a time, but it's not > ready yet.
That is a worthwhile improvement now that sock_sendmsg() can take advantage of multiple pages! It would be pretty invasive though so I think ceph_tcp_sendpage() is better to remain in place until then.
Thanks,
Ilya
| |