Messages in this thread | ![/](/images/icornerl.gif) | | From | Miguel Ojeda <> | Date | Mon, 26 Jun 2023 11:40:33 +0200 | Subject | Re: [PATCH v2] rust: alloc: Add realloc and alloc_zeroed to the GlobalAlloc impl |
| |
On Mon, Jun 26, 2023 at 5:34 AM Martin Rodriguez Reboredo <yakoyoku@gmail.com> wrote: > > I think that this should go above Link and Signed-off-bys, although I'm > not sure if maintainers do it when is merged.
Both styles are used, it is fine either way. Personally, I pick one or the other depending on the kind of comment.
Having said that, there seems to be a missing `From:`, but I can fix that on my side if Björn is the intended author.
> Newbie question, aren't tabs in the commit message verboten?
I am not aware of such a rule, and there are commits in the kernel with tabs, e.g. commit 9828ed3f695a ("module: error out early on concurrent load of the same module file").
In any case, that text doesn't go into the commit message, because it is after the `---` line.
Cheers, Miguel
| ![\](/images/icornerr.gif) |