lkml.org 
[lkml]   [2023]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] rust: alloc: Add realloc and alloc_zeroed to the GlobalAlloc impl
On Mon, Jun 26, 2023 at 5:34 AM Martin Rodriguez Reboredo
<yakoyoku@gmail.com> wrote:
>
> I think that this should go above Link and Signed-off-bys, although I'm
> not sure if maintainers do it when is merged.

Both styles are used, it is fine either way. Personally, I pick one or
the other depending on the kind of comment.

Having said that, there seems to be a missing `From:`, but I can fix
that on my side if Björn is the intended author.

> Newbie question, aren't tabs in the commit message verboten?

I am not aware of such a rule, and there are commits in the kernel
with tabs, e.g. commit 9828ed3f695a ("module: error out early on
concurrent load of the same module file").

In any case, that text doesn't go into the commit message, because it
is after the `---` line.

Cheers,
Miguel

\
 
 \ /
  Last update: 2023-06-26 11:42    [W:0.064 / U:1.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site