Messages in this thread | | | Subject | Re: [PATCH v4 07/24] sched/fair: Compute IPC class scores for load balancing | From | Tim Chen <> | Date | Mon, 26 Jun 2023 14:01:25 -0700 |
| |
On Sun, 2023-06-25 at 13:11 -0700, Ricardo Neri wrote: > > > > + > > > + score_on_dst_cpu = arch_get_ipcc_score(sgs->min_ipcc, env->dst_cpu); > > > + > > > + /* > > > + * Do not use IPC scores. sgs::ipcc_score_{after, before} will be zero > > > + * and not used. > > > + */
The comment is not matching the check below. If zero is not used, the check should also reflect the case.
> > > + if (IS_ERR_VALUE(score_on_dst_cpu)) > > > + return; > > > + > > > + before = sgs->sum_score; > > > + after = before - sgs->min_score; > > > Tim
| |