Messages in this thread | | | Subject | Re: [PATCH v5 4/4] perf tools: Add printing perf_event_attr config symbol in perf_event_attr__fprintf() | From | Yang Jihong <> | Date | Sun, 25 Jun 2023 09:38:27 +0800 |
| |
Hello,
On 2023/6/24 13:28, Namhyung Kim wrote: > Hello, > > On Thu, Jun 22, 2023 at 10:46 PM Yang Jihong <yangjihong1@huawei.com> wrote: >> >> When printing perf_event_attr, always display perf_event_attr config and >> its symbol to improve the readability of debugging information. >> > > [SNIP] >> + >> +#ifdef HAVE_LIBTRACEEVENT >> +static void __p_config_tracepoint_id(char *buf, size_t size, u64 value) >> +{ >> + char *str = tracepoint_id_to_name(value); > > This makes the python module import test failing due to the > undefined symbol. I'll fix it by adding a dummy function in > util/python.c file. But next time, please run `perf test` first > and make sure you don't break anything.
Thanks for the correction.
Running `perf test` on my environment has only one testcase for python:
19:'import perf' in python: Ok
The result is OK. The possible cause is that some libraries are missing in my environment. As a result, other Python tests are not executed. I'll check them first.
Thanks, Yang
| |