Messages in this thread | ![/](/images/icornerl.gif) | | From | Måns Rullgård <> | Subject | Re: [RESEND][PATCH] net: cpsw: fix obtaining mac address for am3517 | Date | Sat, 24 Jun 2023 15:36:24 +0100 |
| |
Andrew Lunn <andrew@lunn.ch> writes:
> On Sat, Jun 24, 2023 at 03:24:47PM +0100, Måns Rullgård wrote: >> Andrew Lunn <andrew@lunn.ch> writes: >> >> > On Sat, Jun 24, 2023 at 01:10:59PM +0100, Mans Rullgard wrote: >> >> From: Jeroen Hofstee <jhofstee@victronenergy.com> >> >> >> >> Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac >> >> id to common file") did not only move the code for an am3517, it also >> >> added the slave parameter, resulting in an invalid (all zero) mac address >> >> being returned for an am3517, since it only has a single emac >> > >> > Hi Mans >> > >> > If there is only a single emac, why is the function being called with >> > slave=1? Given the description, it seems like you are fixing the wrong >> > problem. >> >> See previous discussion: >> https://lore.kernel.org/lkml/d8ad5cab-5183-cddf-fa9a-4e7b9b8c9377@victronenergy.com/ > > Hi Måns > > O.K. did i mention memory of a goldfish? > > This is the sort of detail that should be in the commit > message. Otherwise reviewers are going to ask for an explanation, even > if it has been explained once, 6 years ago. > > I assume you also want this back ported to stable? Please add a Fixed: > tag, and a Cc: stable@vger.kernel.org tag. And set the patch subject > to [PATCH net v3] to indicate this is for the net tree, not net-next.
I give up. It's not worth my time. This is why people hoard patches rather than sending them upstream.
-- Måns Rullgård
| ![\](/images/icornerr.gif) |