lkml.org 
[lkml]   [2023]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] dt-bindings: iio: ad74413r: add binding for digital input threshold
On Fri, Jun 23, 2023 at 01:33:25PM +0200, Rasmus Villemoes wrote:
> Allow specifying the threshold for which the channels configured as
> digital input change state.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
>
> Running dt_binding_check on this with a too small or large value in
> the example does give me an error, but the multipleOf does not seem to
> be enforced; the value 1234567 is not flagged. I don't know if that's
> expected (maybe I have too old versions of something).

That's one for Rob. I checked a few others and behaviour was the same
there.

> .../devicetree/bindings/iio/addac/adi,ad74413r.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml b/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml
> index 590ea7936ad7..1f90ce3c7932 100644
> --- a/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml
> +++ b/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml
> @@ -51,6 +51,14 @@ properties:
> Shunt (sense) resistor value in micro-Ohms.
> default: 100000000
>
> + digital-input-threshold-microvolt:

Should this not have an adi vendor prefix, similar to
"adi,digital-input-threshold-mode-fixed"?

Cheers,
Conor.

> + description:
> + Comparator threshold used by the channels configured to use the
> + digital input function.
> + minimum: 500000
> + maximum: 16000000
> + multipleOf: 500000
> +
> reset-gpios:
> maxItems: 1
>
> @@ -143,6 +151,8 @@ examples:
> refin-supply = <&ad74413r_refin>;
> reset-gpios = <&gpio2 6 GPIO_ACTIVE_LOW>;
>
> + digital-input-threshold-microvolt = <4000000>;
> +
> channel@0 {
> reg = <0>;
>
> --
> 2.37.2
>
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2023-06-23 18:46    [W:1.339 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site