Messages in this thread | | | Date | Fri, 23 Jun 2023 13:57:05 +0800 | Subject | Re: [PATCH net-next 3/6] net: phy: update in-band AN mode when changing interface by PHY driver | From | Choong Yong Liang <> |
| |
Hi Simon,
I will update it in v2. Thank you.
On 22/6/2023 10:43 pm, Simon Horman wrote: > On Thu, Jun 22, 2023 at 12:19:02PM +0800, Choong Yong Liang wrote: >> From: "Tan, Tee Min" <tee.min.tan@linux.intel.com> >> >> Add cur_link_an_mode into phy_device struct for PHY drivers to >> communicate the in-band AN mode setting with phylink framework. >> >> As there is a mechanism in PHY drivers to switch the PHY interface >> between SGMII and 2500BaseX according to link speed. In this case, >> the in-band AN mode should be switching based on the PHY interface >> as well, if the PHY interface has been changed/updated by PHY driver. >> >> For e.g., disable in-band AN in 2500BaseX mode, or enable in-band AN >> back for SGMII mode (10/100/1000Mbps). >> >> Signed-off-by: Tan, Tee Min <tee.min.tan@linux.intel.com> >> Signed-off-by: Choong Yong Liang <yong.liang.choong@linux.intel.com> > > ... > >> diff --git a/include/linux/phy.h b/include/linux/phy.h >> index 11c1e91563d4..c685b526e307 100644 >> --- a/include/linux/phy.h >> +++ b/include/linux/phy.h >> @@ -756,6 +756,8 @@ struct phy_device { >> /* MACsec management functions */ >> const struct macsec_ops *macsec_ops; >> #endif >> + /* For communicate the AN mode setting with phylink framework. */ >> + u8 cur_link_an_mode; >> }; > > Hi Choong Yong Liang, > > Please consider adding cur_link_an_mode to the kernel doc > for struct phy_device - which is above the definition of struct phy_device.
| |