Messages in this thread | | | From | Ian Rogers <> | Date | Fri, 23 Jun 2023 08:00:59 -0700 | Subject | Re: [PATCH v1 01/12] perf expr: Add has_event function |
| |
On Fri, Jun 23, 2023 at 7:40 AM John Garry <john.g.garry@oracle.com> wrote: > > On 23/06/2023 01:33, Ian Rogers wrote: > > + if (!compute_ids) > > + return 0.0; > > + > > + tmp = evlist__new(); > > tmp may be NULL, and parse_event() is not NULL safe, so I assume that we > need to handle tmp == NULL
I'm not sure there's much sensible we can do with this, so I'll turn it into a NAN for v2 - the normal error case.
Thanks, Ian
> > + ret = parse_event(tmp, id) ? 0 : 1; > > + evlist__delete(tmp); > > + return ret; >
| |