lkml.org 
[lkml]   [2023]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 02/39] media: uapi: Add MEDIA_BUS_FMT_RGB666_2X9 variants
    Hi Geert,

    Thank you for the patch.

    On Thu, Jun 22, 2023 at 11:21:14AM +0200, Geert Uytterhoeven wrote:
    > Add the RGB666 9:9 formats MEDIA_BUS_FMT_RGB666_2X9_BE and
    > MEDIA_BUS_FMT_RGB666_2X9_LE. The former is supported by the SH-Mobile
    > LCD Controller.

    If MEDIA_BUS_FMT_RGB666_2X9_LE isn't supported, I'd leave it out for
    now. It can be added later once a driver needs it.

    Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

    > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
    > Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
    > Cc: linux-media@vger.kernel.org
    > ---
    > .../media/v4l/subdev-formats.rst | 144 ++++++++++++++++++
    > include/uapi/linux/media-bus-format.h | 4 +-
    > 2 files changed, 147 insertions(+), 1 deletion(-)
    >
    > diff --git a/Documentation/userspace-api/media/v4l/subdev-formats.rst b/Documentation/userspace-api/media/v4l/subdev-formats.rst
    > index a3a35eeed70846ba..4bbcdec101384cb1 100644
    > --- a/Documentation/userspace-api/media/v4l/subdev-formats.rst
    > +++ b/Documentation/userspace-api/media/v4l/subdev-formats.rst
    > @@ -949,6 +949,150 @@ The following tables list existing packed RGB formats.
    > - b\ :sub:`2`
    > - b\ :sub:`1`
    > - b\ :sub:`0`
    > + * .. _MEDIA-BUS-FMT-RGB666-2X9-BE:
    > +
    > + - MEDIA_BUS_FMT_RGB666_2X9_BE
    > + - 0x1025
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + - r\ :sub:`5`
    > + - r\ :sub:`4`
    > + - r\ :sub:`3`
    > + - r\ :sub:`2`
    > + - r\ :sub:`1`
    > + - r\ :sub:`0`
    > + - g\ :sub:`5`
    > + - g\ :sub:`4`
    > + - g\ :sub:`3`
    > + * -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + - g\ :sub:`2`
    > + - g\ :sub:`1`
    > + - g\ :sub:`0`
    > + - b\ :sub:`5`
    > + - b\ :sub:`4`
    > + - b\ :sub:`3`
    > + - b\ :sub:`2`
    > + - b\ :sub:`1`
    > + - b\ :sub:`0`
    > + * .. _MEDIA-BUS-FMT-RGB666-2X9-LE:
    > +
    > + - MEDIA_BUS_FMT_RGB666_2X9_LE
    > + - 0x1026
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + - g\ :sub:`2`
    > + - g\ :sub:`1`
    > + - g\ :sub:`0`
    > + - b\ :sub:`5`
    > + - b\ :sub:`4`
    > + - b\ :sub:`3`
    > + - b\ :sub:`2`
    > + - b\ :sub:`1`
    > + - b\ :sub:`0`
    > + * -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + -
    > + - r\ :sub:`5`
    > + - r\ :sub:`4`
    > + - r\ :sub:`3`
    > + - r\ :sub:`2`
    > + - r\ :sub:`1`
    > + - r\ :sub:`0`
    > + - g\ :sub:`5`
    > + - g\ :sub:`4`
    > + - g\ :sub:`3`
    > * .. _MEDIA-BUS-FMT-BGR666-1X18:
    >
    > - MEDIA_BUS_FMT_BGR666_1X18
    > diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h
    > index a03c543cb072de30..07105f530400511e 100644
    > --- a/include/uapi/linux/media-bus-format.h
    > +++ b/include/uapi/linux/media-bus-format.h
    > @@ -34,7 +34,7 @@
    >
    > #define MEDIA_BUS_FMT_FIXED 0x0001
    >
    > -/* RGB - next is 0x1025 */
    > +/* RGB - next is 0x1027 */
    > #define MEDIA_BUS_FMT_RGB444_1X12 0x1016
    > #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001
    > #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002
    > @@ -46,6 +46,8 @@
    > #define MEDIA_BUS_FMT_RGB565_2X8_BE 0x1007
    > #define MEDIA_BUS_FMT_RGB565_2X8_LE 0x1008
    > #define MEDIA_BUS_FMT_RGB666_1X18 0x1009
    > +#define MEDIA_BUS_FMT_RGB666_2X9_BE 0x1025
    > +#define MEDIA_BUS_FMT_RGB666_2X9_LE 0x1026
    > #define MEDIA_BUS_FMT_BGR666_1X18 0x1023
    > #define MEDIA_BUS_FMT_RBG888_1X24 0x100e
    > #define MEDIA_BUS_FMT_RGB666_1X24_CPADHI 0x1015

    --
    Regards,

    Laurent Pinchart

    \
     
     \ /
      Last update: 2023-06-23 16:58    [W:4.104 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site