Messages in this thread | | | Subject | Re: [net-next Patch 1/3] octeontx2-pf: implement transmit schedular allocation algorithm | From | Paolo Abeni <> | Date | Fri, 23 Jun 2023 15:01:09 +0200 |
| |
On Thu, 2023-06-22 at 14:26 +0530, Hariprasad Kelam wrote: > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/qos.h b/drivers/net/ethernet/marvell/octeontx2/nic/qos.h > index 19773284be27..0c5d2f79dc15 100644 > --- a/drivers/net/ethernet/marvell/octeontx2/nic/qos.h > +++ b/drivers/net/ethernet/marvell/octeontx2/nic/qos.h > @@ -35,6 +35,7 @@ struct otx2_qos_cfg { > int dwrr_node_pos[NIX_TXSCH_LVL_CNT]; > u16 schq_contig_list[NIX_TXSCH_LVL_CNT][MAX_TXSCHQ_PER_FUNC]; > u16 schq_list[NIX_TXSCH_LVL_CNT][MAX_TXSCHQ_PER_FUNC]; > + u16 schq_used_index[NIX_TXSCH_LVL_CNT][MAX_TXSCHQ_PER_FUNC];
This struct is already quite big, and you use schq_used_index[x][y] as a bool. I think you will be better off changing the used type accordingly.
Side note 'schq_index_used' sounds a little more clear to me, but could be simply ENONATIVELANG here ;)
Cheers,
Paolo
| |