Messages in this thread | | | Date | Fri, 23 Jun 2023 13:49:47 +0100 | From | Marc Zyngier <> | Subject | Re: [PATCH v4 08/10] irqchip: Add RISC-V advanced PLIC driver |
| |
[here, let me trim all of this nonsense...]
On Fri, 23 Jun 2023 12:47:00 +0100, Anup Patel <apatel@ventanamicro.com> wrote: > > No. My previous email asking you to NOT use IRQCHIP_DECLARE() and > > instead use IRQCHIP_PLATFORM_DRIVER_BEGIN/END() macros. > > I tried IRQCHIP_PLATFORM_DRIVER_BEGIN/END() macros but these > macros are not suitable for APLIC driver because we need platform device > pointer in the APLIC probe() to create platform MSI device domain (refer, > platform_msi_create_device_domain()).
Oh come on. How hard have you tried? Have you even looked at the other drivers in the tree to see how they solve this insurmountable problem with a *single* line of code?
pdev = of_find_device_by_node(node);
That's it.
> Further, I tried setting the "suppress_bind_attrs" flag in "struct > platform_driver aplic_driver" just like the > IRQCHIP_PLATFORM_DRIVER_END() macro but this did not work.
I'm not sure how relevant this is to the conversation.
M.
-- Without deviation from the norm, progress is not possible.
| |