lkml.org 
[lkml]   [2023]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Subject[PATCH net-next v2 00/10] net: phy: C45-over-C22 access
    Date
    [Sorry for the very late follow-up on this series, I simply haven't had
    time to look into it. Should be better now.]

    The goal here is to get the GYP215 and LAN8814 running on the Microchip
    LAN9668 SoC. The LAN9668 suppports one external bus and unfortunately, the
    LAN8814 has a bug which makes it impossible to use C45 on that bus.
    Fortunately, it was the intention of the GPY215 driver to be used on a C22
    bus. But I think this could have never really worked, because the
    phy_get_c45_ids() will always do c45 accesses and thus gpy_probe() will
    fail.

    Introduce C45-over-C22 support and use it if the MDIO bus doesn't support
    C45 in the OF case. We must not use C45-over-C22 if the device being
    probed isn't a PHY because it involes register writes to standard PHY
    registers, which might not be supported in generic PHY devices.
    Therefore, we cannot use it in the generic PHY probing code. In the DT
    case, we know we are probing a PHY device and thus we can fall back to
    C45-over-C22.

    The first patches convert the is_c45 property to a new "enum
    phy_access_mode". The former property is then derived from the
    access mode.

    To support the probing for DT, export the prevent_c45_scan logic and
    make it a property of the mii bus. Unfortunately, you'd need to stick to
    the following flow in every scanning code:
    (1) add any c22 phys
    (2) scan for broken phys
    (3) add any c45 phys using either c45 or c45-over-c22 access

    I couldn't find a way to make that generic and move the flow into the
    phy core.

    Then, a new access method c45-over-c22 is added for get_phy_device() and
    phy_{read,write}_mmd(). It is the callers responsibilty to choose the
    correct mode. Esp. the generic probing code isn't using c45-over-c22.

    c45-over-c22 is then added for the MaxLinear PHYs if it is probed as a
    C22 device, which is always the case if there is no compatible =
    "ethernet-phy-ieee802.3-c45" in the device tree. The driver will
    automatically "promote" the PHY to a C45 one if probed as C22.

    The last two patches will then add c45-over-c22 fallback to the DT PHY
    registration code. As described above, the probing is split into the
    three phases.

    FWIW, this now triggers a bug in mscc-miim. Haven't figured out what's
    wrong yet, somehow the status register doesn't return busy/pending.
    Currently, working around that with a sleep.

    net: phy: add error checks in mmd_phy_indirect() and export it
    net: phy: get rid of redundant is_c45 information
    net: phy: introduce phy_is_c45()
    net: phy: replace is_c45 with phy_accces_mode
    net: phy: make the "prevent_c45_scan" a property of the MII bus
    net: phy: print an info if a broken C45 bus is found
    net: phy: add support for C45-over-C22 transfers
    net: phy: introduce phy_promote_to_c45()
    net: mdio: add C45-over-C22 fallback to fwnode_mdiobus_register_phy()
    net: mdio: scan for broken C22 PHYs when probed via OF

    Changes since v1:
    - major rework to address the problem to not use c45-over-c22 on
    bus scanning, see the description above. Except from some preparation
    patches there is little left of the original series. The major
    difference is that there is now a new transport mode argument and the
    c45-over-c22 is not automatically used anymore.
    - Link: https://lore.kernel.org/netdev/20230120224011.796097-1-michael@walle.cc/

    Changes since RFC v2:
    - Reased to latest net-next
    - new check_rc argument in mmd_phy_indirect() to retain old behavior
    - determine bus capabilities by bus->read and bus->read_c45
    - always set phydev->c45_over_c22 if PHY is promoted
    - Link: https://lore.kernel.org/netdev/20220325213518.2668832-1-michael@walle.cc/

    Changes since RFC v1:
    - use __phy_mmd_indirect() in mdiobus_probe_mmd_read()
    - add new properties has_c45 c45_over_c22 (and remove is_c45)
    - drop MDIOBUS_NO_CAP handling, Andrew is preparing a series to
    add probe_capabilities to mark all C45 capable MDIO bus drivers
    - Link: https://lore.kernel.org/netdev/20220323183419.2278676-1-michael@walle.cc/

    Signed-off-by: Michael Walle <mwalle@kernel.org>
    ---
    Michael Walle (10):
    net: phy: add error checks in mmd_phy_indirect() and export it
    net: phy: get rid of redundant is_c45 information
    net: phy: introduce phy_is_c45()
    net: phy: replace is_c45 with phy_accces_mode
    net: phy: make the "prevent_c45_scan" a property of the MII bus
    net: phy: print an info if a broken C45 bus is found
    net: phy: add support for C45-over-C22 transfers
    net: phy: introduce phy_promote_to_c45()
    net: mdio: add C45-over-C22 fallback to fwnode_mdiobus_register_phy()
    net: mdio: support C45-over-C22 when probed via OF

    drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 8 +-
    drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 4 +-
    drivers/net/mdio/fwnode_mdio.c | 19 ++-
    drivers/net/mdio/of_mdio.c | 63 +++++++---
    drivers/net/phy/bcm84881.c | 2 +-
    drivers/net/phy/marvell10g.c | 2 +-
    drivers/net/phy/mdio_bus.c | 33 ++---
    drivers/net/phy/mxl-gpy.c | 9 +-
    drivers/net/phy/nxp-tja11xx.c | 3 +-
    drivers/net/phy/phy-core.c | 105 +++++++++++-----
    drivers/net/phy/phy.c | 8 +-
    drivers/net/phy/phy_device.c | 139 +++++++++++++++++-----
    drivers/net/phy/phylink.c | 10 +-
    drivers/net/phy/sfp.c | 12 +-
    include/linux/phy.h | 48 ++++++--
    15 files changed, 331 insertions(+), 134 deletions(-)
    ---
    base-commit: 5e218791dc7b2b57c90d5942ab6bae4bc2ab0ead
    change-id: 20230620-feature-c45-over-c22-0a2181babd56

    \
     
     \ /
      Last update: 2023-06-23 12:29    [W:2.810 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site