lkml.org 
[lkml]   [2023]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v1 1/8] drm/etnaviv: Using the size_t variable to store the number of pages
    Date
    From: Sui Jingfeng <suijingfeng@loongson.cn>

    Because the etnaviv_gem_new_private() function receives the size_t argument
    for the number of pages. And the number of pages should be unsigned.

    Note that Most 32-bit architectures use "unsigned int" size_t,
    and all 64-bit architectures use "unsigned long" size_t.
    So, let's keep the argument and parameter consistent.

    Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
    ---
    drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
    index 3524b5811682..b003481adc2b 100644
    --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
    +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
    @@ -114,7 +114,8 @@ struct drm_gem_object *etnaviv_gem_prime_import_sg_table(struct drm_device *dev,
    {
    struct etnaviv_gem_object *etnaviv_obj;
    size_t size = PAGE_ALIGN(attach->dmabuf->size);
    - int ret, npages;
    + size_t npages = size / PAGE_SIZE;
    + int ret;

    ret = etnaviv_gem_new_private(dev, size, ETNA_BO_WC,
    &etnaviv_gem_prime_ops, &etnaviv_obj);
    @@ -123,8 +124,6 @@ struct drm_gem_object *etnaviv_gem_prime_import_sg_table(struct drm_device *dev,

    lockdep_set_class(&etnaviv_obj->lock, &etnaviv_prime_lock_class);

    - npages = size / PAGE_SIZE;
    -
    etnaviv_obj->sgt = sgt;
    etnaviv_obj->pages = kvmalloc_array(npages, sizeof(struct page *), GFP_KERNEL);
    if (!etnaviv_obj->pages) {
    --
    2.25.1
    \
     
     \ /
      Last update: 2023-06-23 12:18    [W:6.280 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site