Messages in this thread | | | From | Kyle Tso <> | Date | Fri, 23 Jun 2023 18:08:34 +0800 | Subject | Re: [PATCH 1/3] usb: typec: Set port->pd before adding device for typec_port |
| |
On Fri, Jun 23, 2023 at 3:50 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > On Thu, Jun 22, 2023 at 11:04:21PM +0800, Kyle Tso wrote: > > When calling device_add in the registration of typec_port, it will do > > the NULL check on usb_power_delivery handle in typec_port for the > > visibility of the device attributes. It is always NULL because port->pd > > is set in typec_port_set_usb_power_delivery which is later than the > > device_add call. > > > > Set port->pd before device_add and only link the device after that. > > > > Fixes: a7cff92f0635 ("usb: typec: USB Power Delivery helpers for ports and partners") > > Signed-off-by: Kyle Tso <kyletso@google.com> > > Shouldn't all of these also have a cc: stable@ line in them as well? > > thanks, > > greg k-h
Will do in v2
Kyle
| |