Messages in this thread | ![/](/images/icornerl.gif) | | From | Namhyung Kim <> | Date | Fri, 23 Jun 2023 16:52:04 -0700 | Subject | Re: [PATCH v3 2/7] perf metric: Event "Compat" value supports matching multiple identifiers |
| |
Hello,
On Wed, Jun 14, 2023 at 8:42 PM Jing Zhang <renyu.zj@linux.alibaba.com> wrote: > > > > 在 2023/6/6 上午3:39, Arnaldo Carvalho de Melo 写道: > > Em Mon, Jun 05, 2023 at 10:46:36AM +0800, Jing Zhang escreveu: > >> 在 2023/6/3 上午12:20, John Garry 写道: > >>> On 01/06/2023 09:58, Jing Zhang wrote: > >>>> It can match identifiers "arm_cmn600_{0,1,2..X}" or "arm_cmn650_{0,1,2..X}" or "arm_cmn700_{0,1,2..X}" or "arm_ci700_{ 0,1,2..X}". > >>>> In other words, it can match all identifiers prefixed with “arm_cmn600” or “arm_cmn650” or “arm_cmn700” or “arm_ci700”. > >>>> > >>>> If a new model arm_cmn driver with identifier "arm_cmn750_0", it will not be matched, but if a new revision arm_cmn driver with identifier > >>>> "arm_cmn700_4", it can be matched. > >>> > >>> OK, I see what you mean. My confusion came about though your commit message on this same patch, which did not mention cmn650. I assumed that the example event which you were describing was supported for arm_cmn650 and you intentionally omitted it. > >>> > >> > >> Yes, I didn't write cmn650 in the commit message, just because I omitted it. I will add it in a later version. > > > > Ok, will wait for v4 then. > > > > - Arnaldo > > Hi Arnaldo, > > Thank you for following up this patchset, maybe we can merge patch4 to patch7 into your branch first? > They have all been reviewed/acked and there is no dispute. And patch4-7 does not depend on patch1-3, > because patch4-7 is about the metric of ali_drw_pmu, and patch1-3 is about the metric of arm_cmn. > It may take some time for patch1-3 to reach a consensus.
IIUC patch 4 is for the kernel and patch 5-7 semantically depend on it. So the patch 4 should be picked up by the kernel maintainers first.
Thanks, Namhyung
| ![\](/images/icornerr.gif) |