| Date | Wed, 21 Jun 2023 18:35:06 +0200 | From | Jan Kara <> | Subject | Re: [PATCH 04/79] binderfs: switch to new ctime accessors |
| |
On Wed 21-06-23 10:45:17, Jeff Layton wrote: > In later patches, we're going to change how the ctime.tv_nsec field is > utilized. Switch to using accessor functions instead of raw accesses of > inode->i_ctime. > > Signed-off-by: Jeff Layton <jlayton@kernel.org>
Looks good to me. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> --- > drivers/android/binderfs.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c > index 76e7d6676657..b6b1220e1e55 100644 > --- a/drivers/android/binderfs.c > +++ b/drivers/android/binderfs.c > @@ -153,7 +153,7 @@ static int binderfs_binder_device_create(struct inode *ref_inode, > goto err; > > inode->i_ino = minor + INODE_OFFSET; > - inode->i_mtime = inode->i_atime = inode->i_ctime = current_time(inode); > + inode->i_mtime = inode->i_atime = inode_ctime_set_current(inode); > init_special_inode(inode, S_IFCHR | 0600, > MKDEV(MAJOR(binderfs_dev), minor)); > inode->i_fop = &binder_fops; > @@ -432,7 +432,7 @@ static int binderfs_binder_ctl_create(struct super_block *sb) > } > > inode->i_ino = SECOND_INODE; > - inode->i_mtime = inode->i_atime = inode->i_ctime = current_time(inode); > + inode->i_mtime = inode->i_atime = inode_ctime_set_current(inode); > init_special_inode(inode, S_IFCHR | 0600, > MKDEV(MAJOR(binderfs_dev), minor)); > inode->i_fop = &binder_ctl_fops; > @@ -474,7 +474,7 @@ static struct inode *binderfs_make_inode(struct super_block *sb, int mode) > if (ret) { > ret->i_ino = iunique(sb, BINDERFS_MAX_MINOR + INODE_OFFSET); > ret->i_mode = mode; > - ret->i_atime = ret->i_mtime = ret->i_ctime = current_time(ret); > + ret->i_atime = ret->i_mtime = inode_ctime_set_current(ret); > } > return ret; > } > @@ -703,7 +703,7 @@ static int binderfs_fill_super(struct super_block *sb, struct fs_context *fc) > inode->i_ino = FIRST_INODE; > inode->i_fop = &simple_dir_operations; > inode->i_mode = S_IFDIR | 0755; > - inode->i_mtime = inode->i_atime = inode->i_ctime = current_time(inode); > + inode->i_mtime = inode->i_atime = inode_ctime_set_current(inode); > inode->i_op = &binderfs_dir_inode_operations; > set_nlink(inode, 2); > > -- > 2.41.0 > -- Jan Kara <jack@suse.com> SUSE Labs, CR
|