| Date | Thu, 15 Jun 2023 15:08:07 -0700 | Subject | Re: [PATCH v4 06/24] x86/resctrl: Track the number of dirty RMID a CLOSID has | From | Reinette Chatre <> |
| |
Hi James,
On 5/25/2023 11:01 AM, James Morse wrote:
...
> @@ -391,6 +407,8 @@ static void add_rmid_to_limbo(struct rmid_entry *entry) > u64 val = 0; > u32 idx; > > + lockdep_assert_held(&rdtgroup_mutex); > + > idx = resctrl_arch_rmid_idx_encode(entry->closid, entry->rmid); > > entry->busy = 0; > @@ -420,6 +438,9 @@ static void add_rmid_to_limbo(struct rmid_entry *entry) > rmid_limbo_count++; > else > list_add_tail(&entry->list, &rmid_free_lru); > + > + if (IS_ENABLED(CONFIG_RESCTRL_RMID_DEPENDS_ON_CLOSID)) > + closid_num_dirty_rmid[entry->closid]++;
Wouldn't this always increment the counter, whether the entry is dirty or not? (Although ... the later change where entries are always dirty may make this correct ... although I would still expect the if statement that precedes it to change).
Reinette
|