lkml.org 
[lkml]   [2023]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [patch 12/17] init: Invoke arch_cpu_finalize_init() earlier
    Date
    On Wed, 2023-06-14 at 01:39 +0200, Thomas Gleixner wrote:
    > Fortunately none of the init calls between calibrate_delay() and
    > arch_cpu_finalize_init() is relevant for the functionality of
    > arch_cpu_finalize_init().
    >

    Reviewed-by: Rick Edgecombe <rick.p.edgecombe@intel.com>

    I did my best to find a counterpoint to this statement. The only thing
    I found was that lockdep_init_task(&init_task) in fork_init() is now
    called after the spin_lock() usage in set_memory_4k(). But AFAICT, that
    whole lockdep_init_task() call is unneeded because the fields it sets
    are already statically initialized. I mention only because I'm not 100%
    sure the lockdep_init_task() call is not serving some purpose I'm
    missing.
    \
     
     \ /
      Last update: 2023-06-15 23:45    [W:3.195 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site