Messages in this thread | | | From | Vincent Legoll <> | Date | Wed, 14 Jun 2023 14:19:06 +0000 | Subject | Re: [PATCH v5 00/25] Add perf support to the rockchip-dfi driver |
| |
Hello Sascha, Sebastian,
On Wed, Jun 14, 2023 at 1:40 PM Sebastian Reichel <sebastian.reichel@collabora.com> wrote: > On Wed, May 24, 2023 at 10:31:28AM +0200, Sascha Hauer wrote: > > This is v5 of the series adding perf support to the rockchip DFI driver. > > [...] > > The RK3588 device tree changes for the DFI were not part of v4. As > > Vincent Legoll showed interest in testing this series the necessary > > device tree changes are now part of this series. > > I tested the series on RK3588 EVB1. The read/write byts looks > sensible. Sometimes cycles reads unrealistic values, though: > [...] > Otherwise the series is > > Tested-by: Sebastian Reichel <sebastian.reichel@collabora.com> > > -- Sebastian
I also tested this new version of the series on a Pine64 QuartzPro64 dev board.
I applied the series on top of my local branch, which is based on Collabora's rockchip-3588 plus some QP64 DTS patches, and your V5 patch series.
Looks like this is still working properly:
-bash-5.1# uname -a Linux qp64 6.4.0-rc1-00140-g658dd2200e2a #24 SMP PREEMPT Wed Jun 14 15:50:34 CEST 2023 aarch64 GNU/Linux
-bash-5.1# zgrep -i _dfi /proc/config.gz CONFIG_DEVFREQ_EVENT_ROCKCHIP_DFI=y
-bash-5.1# perf list | grep rockchip_ddr rockchip_ddr/bytes/ [Kernel PMU event] rockchip_ddr/cycles/ [Kernel PMU event] rockchip_ddr/read-bytes/ [Kernel PMU event] rockchip_ddr/read-bytes0/ [Kernel PMU event] rockchip_ddr/read-bytes1/ [Kernel PMU event] rockchip_ddr/read-bytes2/ [Kernel PMU event] rockchip_ddr/read-bytes3/ [Kernel PMU event] rockchip_ddr/write-bytes/ [Kernel PMU event] rockchip_ddr/write-bytes0/ [Kernel PMU event] rockchip_ddr/write-bytes1/ [Kernel PMU event] rockchip_ddr/write-bytes2/ [Kernel PMU event] rockchip_ddr/write-bytes3/ [Kernel PMU event]
# With no memory load -bash-5.1# perf stat -a -e rockchip_ddr/cycles/,rockchip_ddr/read-bytes/,rockchip_ddr/write-bytes/,rockchip_ddr/bytes/ sleep 1
Performance counter stats for 'system wide':
1058691047 rockchip_ddr/cycles/ 9.35 MB rockchip_ddr/read-bytes/ 0.57 MB rockchip_ddr/write-bytes/ 9.90 MB rockchip_ddr/bytes/
1.002616498 seconds time elapsed
# With a hog -bash-5.1# memtester 4G > /dev/null 2>&1 & -bash-5.1# perf stat -a -e rockchip_ddr/cycles/,rockchip_ddr/read-bytes/,rockchip_ddr/write-bytes/,rockchip_ddr/bytes/ sleep 10
Performance counter stats for 'system wide':
10561540038 rockchip_ddr/cycles/ 60212.59 MB rockchip_ddr/read-bytes/ 31313.03 MB rockchip_ddr/write-bytes/ 91525.60 MB rockchip_ddr/bytes/
10.001651886 seconds time elapsed
You can add my T-B, for the whole series:
Tested-by: Vincent Legoll <vincent.legoll@gmail.com>
Or is there something else you want me to test ?
Thanks for your work Regards
-- Vincent Legoll
| |