| Date | Wed, 14 Jun 2023 13:41:20 +0200 | Subject | Re: [PATCH v2 01/15] dt-bindings: display: mediatek: ethdr: Add compatible for MT8188 | From | AngeloGioacchino Del Regno <> |
| |
Il 14/06/23 09:31, Hsiao Chien Sung ha scritto: > Add compatible name for MediaTek MT8188 ETHDR. > > Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com> > --- > .../bindings/display/mediatek/mediatek,ethdr.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.yaml > index 801fa66ae615..677882348ede 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.yaml > @@ -23,7 +23,11 @@ description: > > properties: > compatible: > - const: mediatek,mt8195-disp-ethdr > + oneOf: > + - const: mediatek,mt8195-disp-ethdr > + - items: > + - const: mediatek,mt8188-disp-ethdr > + - const: mediatek,mt8195-disp-ethdr >
Is MT8188's ETHDR fully compatible with MT8195's ETHDR?
If it is, you're not adding a mt8188 specific compatible string in the driver and this means that the devicetree will look like:
compatible = "mediatek,mt8195-disp-ethdr", "mediatek,mt8188-disp-ethdr"
...so the proposed doc change works.
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> reg: > maxItems: 7 > -- > 2.18.0 >
|