Messages in this thread | | | From | Rob Herring <> | Subject | Re: [PATCH 2/8] dt-bindings: rtc: Move isil,isl12022 from trivial-rtc.yaml into own schema file | Date | Mon, 12 Jun 2023 06:26:39 -0600 |
| |
On Mon, 12 Jun 2023 13:30:52 +0200, Rasmus Villemoes wrote: > Move the isil,isl12022 RTC bindings from trivial-rtc.yaml into its own > intersil,isl12022.yaml file, in preparation for adding more bindings. > > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> > --- > .../bindings/rtc/intersil,isl12022.yaml | 42 +++++++++++++++++++ > .../devicetree/bindings/rtc/trivial-rtc.yaml | 2 - > 2 files changed, 42 insertions(+), 2 deletions(-) > create mode 100644 Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml >
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors: Traceback (most recent call last): File "/usr/local/bin/dt-doc-validate", line 62, in <module> ret |= check_doc(f) File "/usr/local/bin/dt-doc-validate", line 31, in check_doc for error in sorted(dtschema.DTValidator.iter_schema_errors(testtree), key=lambda e: e.linecol): File "/usr/local/lib/python3.10/dist-packages/dtschema/lib.py", line 736, in iter_schema_errors cls.annotate_error(error, meta_schema, error.schema_path) File "/usr/local/lib/python3.10/dist-packages/dtschema/lib.py", line 712, in annotate_error schema = schema[p] KeyError: 'type' /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml: 'maintainers' is a required property hint: Metaschema for devicetree binding documentation from schema $id: http://devicetree.org/meta-schemas/base.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230612113059.247275-3-linux@rasmusvillemoes.dk
The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
| |