lkml.org 
[lkml]   [2023]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 2/3] dt-bindings: iio: adc: Add Allwinner D1/T113s/R329/T507 SoCs GPADC
    On Sat, Jun 10, 2023 at 11:19:49PM +0300, Maksim Kiselev wrote:
    > From: Maxim Kiselev <bigunclemax@gmail.com>
    >
    > Allwinner's D1/T113s/R329/T507 SoCs have a new general purpose ADC.
    > This ADC is the same for all of this SoCs. The only difference is
    > the number of available channels.
    >
    > Signed-off-by: Maxim Kiselev <bigunclemax@gmail.com>

    Looks fine to me chief.
    Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

    > ---
    > .../iio/adc/allwinner,sun20i-d1-gpadc.yaml | 91 +++++++++++++++++++
    > 1 file changed, 91 insertions(+)
    > create mode 100644 Documentation/devicetree/bindings/iio/adc/allwinner,sun20i-d1-gpadc.yaml
    >
    > diff --git a/Documentation/devicetree/bindings/iio/adc/allwinner,sun20i-d1-gpadc.yaml b/Documentation/devicetree/bindings/iio/adc/allwinner,sun20i-d1-gpadc.yaml
    > new file mode 100644
    > index 000000000000..43256ad2b7ed
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/iio/adc/allwinner,sun20i-d1-gpadc.yaml
    > @@ -0,0 +1,91 @@
    > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
    > +%YAML 1.2
    > +---
    > +$id: http://devicetree.org/schemas/iio/adc/allwinner,sun20i-d1-gpadc.yaml#
    > +$schema: http://devicetree.org/meta-schemas/core.yaml#
    > +
    > +title: Allwinner D1 General Purpose ADC
    > +
    > +maintainers:
    > + - Maksim Kiselev <bigunclemax@gmail.com>
    > +
    > +properties:
    > + compatible:
    > + enum:
    > + - allwinner,sun20i-d1-gpadc

    btw, do you intend coming along later and adding some of the other ones,
    or do you only have the d1 yourself?

    Cheers,
    Conor.
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2023-06-11 00:18    [W:8.947 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site