lkml.org 
[lkml]   [2023]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/2] iio: adc: max14001: New driver
On Fri, 9 Jun 2023 01:55:17 +0800
Kim Seer Paller <kimseer.paller@analog.com> wrote:

> The MAX14001 is configurable, isolated 10-bit ADCs for multi-range
> binary inputs.
>
> Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com>
The driver initialises a regmap then doesn't use it.
Fine not to use it, but get rid of the setup code, structures and include
as well. I assume this got forgotten after testing the code worked when it
wasn't used.

Other than that looks fine to me.

Jonathan


\
 
 \ /
  Last update: 2023-06-10 20:01    [W:0.076 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site