lkml.org 
[lkml]   [2023]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 05/12] dt-bindings: remoteproc: Add Qualcomm RPM processor/subsystem
From
On 08/06/2023 09:10, Stephan Gerhold wrote:
> On Qualcomm platforms, most subsystems (e.g. audio/modem DSP) are
> described as remote processors in the device tree, with a dedicated
> node where properties and services related to them can be described.


Thank you for your patch. There is something to discuss/improve.


> +
> + smd-edge:
> + $ref: /schemas/remoteproc/qcom,smd-edge.yaml#
> + description:
> + Qualcomm Shared Memory subnode which represents communication edge,
> + channels and devices related to the RPM subsystem.
> +
> + glink-rpm:

This should be "glink-edge", to be a bit more generic and match existing
smd-edge.

> + $ref: /schemas/remoteproc/qcom,glink-rpm-edge.yaml#
> + description:
> + Qualcomm G-Link subnode which represents communication edge,
> + channels and devices related to the RPM subsystem.
> +
> + interrupt-controller:
> + type: object
> + $ref: /schemas/interrupt-controller/qcom,mpm.yaml#
> + description:
> + MSM Power Manager (MPM) interrupt controller that monitors interrupts
> + when the system is asleep.
> +
> + master-stats:
> + $ref: /schemas/soc/qcom/qcom,rpm-master-stats.yaml#
> + description:
> + Subsystem-level low-power mode statistics provided by RPM.
> +
> +required:
> + - compatible
> +


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2023-06-10 18:44    [W:0.205 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site