Messages in this thread | | | Date | Sat, 10 Jun 2023 16:39:59 +0100 | From | Conor Dooley <> | Subject | Re: [PATCH V2 3/4] riscv: hibernate: remove WARN_ON in save_processor_state |
| |
On Fri, Jun 09, 2023 at 03:50:48PM +0800, Song Shuai wrote: > During hibernation or restoration, freeze_secondary_cpus > checks num_online_cpus via BUG_ON, and the subsequent > save_processor_state also does the checking with WARN_ON. > > In the case of CONFIG_PM_SLEEP_SMP=n, freeze_secondary_cpus > is not defined, but the sole possible condition to disable > CONFIG_PM_SLEEP_SMP is !SMP where num_online_cpus is always 1. > We also don't have to check it in save_processor_state. > > So remove the unnecessary checking in save_processor_state.
In the future, please write function with a () in commit messages, so freeze_secondary_cpus() etc. Otherwise, Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks, Conor.
> > Fixes: c0317210012e ("RISC-V: Add arch functions to support hibernation/suspend-to-disk") > Signed-off-by: Song Shuai <songshuaishuai@tinylab.org> > --- > arch/riscv/kernel/hibernate.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/riscv/kernel/hibernate.c b/arch/riscv/kernel/hibernate.c > index 395f835f067c..86f1c9ab6b0b 100644 > --- a/arch/riscv/kernel/hibernate.c > +++ b/arch/riscv/kernel/hibernate.c > @@ -119,7 +119,6 @@ int pfn_is_nosave(unsigned long pfn) > > void notrace save_processor_state(void) > { > - WARN_ON(num_online_cpus() != 1); > } > > void notrace restore_processor_state(void) > -- > 2.20.1 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv [unhandled content-type:application/pgp-signature] | |