lkml.org 
[lkml]   [2023]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Subject[PATCH v2 0/2] leds: trigger: netdev: add additional modes
    Date
    This is a continue of [1]. It was decided to take a more gradual
    approach to implement LEDs support for switch and phy starting with
    basic support and then implementing the hw control part when we have all
    the prereq done.

    This should be the final part for the netdev trigger.

    We collect some info around and we found a good set of modes that are
    common in almost all the PHY and Switch.

    These modes are:
    - Modes for dedicated link speed(10, 100, 1000 mbps). Additional mode
    can be added later following this example.
    - Modes for half and full duplex.

    The original idea was to add hw control only modes.
    While the concept makes sense in practice it would results in lots of
    additional code and extra check to make sure we are setting correct modes.

    With the suggestion from Andrew it was pointed out that using the ethtool
    APIs we can actually get the current link speed and duplex and this
    effectively removed the problem of having hw control only modes since we
    can fallback to software.

    Since these modes are supported by software, we can skip providing an
    user for this in the LED driver to support hw control for these new modes
    (that will come right after this is merged) and prevent this to be another
    multi subsystem series.

    For link speed and duplex we use ethtool APIs.

    To call ethtool APIs, rtnl lock is needed but this can be skipped on
    handling netdev events as the lock is already held.

    [1] https://lore.kernel.org/lkml/20230216013230.22978-1-ansuelsmth@gmail.com/

    Changes v2:
    - Drop ACTIVITY patch as it can be handled internally in the LED driver
    - Reduce duplicate code and move the link state to a dedicated helper

    Christian Marangi (2):
    leds: trigger: netdev: add additional specific link speed mode
    leds: trigger: netdev: add additional specific link duplex mode

    drivers/leds/trigger/ledtrig-netdev.c | 103 +++++++++++++++++++++++---
    include/linux/leds.h | 5 ++
    2 files changed, 98 insertions(+), 10 deletions(-)

    --
    2.40.1

    \
     
     \ /
      Last update: 2023-06-10 15:10    [W:4.434 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site