lkml.org 
[lkml]   [2023]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/2] genirq/msi, platform-msi: Adjust return value of msi_domain_prepare_irqs()
    Hi, Thomas,

    On Tue, May 30, 2023 at 11:03 PM Thomas Gleixner <tglx@linutronix.de> wrote:
    >
    > On Tue, May 30 2023 at 16:34, Huacai Chen wrote:
    > > On Tue, May 30, 2023 at 4:19 AM Thomas Gleixner <tglx@linutronix.de> wrote:
    > >> Let's take a step back and look at the larger picture:
    > >>
    > >> 1) A PCI/MSI irqdomain is attached to a PCI bus
    > >>
    > >> 2) The number of PCI devices on that PCI bus is usually known at boot
    > >> time _before_ the first device driver is probed.
    > >>
    > >> That's not entirely true for PCI hotplug devices, but that's hardly
    > >> relevant for an architecture which got designed less than 10 years
    > >> ago and the architects decided that 256 MSI vectors are good enough
    > >> for up to 256 CPUs. The concept of per CPU queues was already known
    > >> at that time, no?
    > > Does this solution depend on the per-device msi domain? Can we do that
    > > if we use the global msi domain?
    >
    > In principle it should not depend on per-device MSI domains, but I
    > really don't want to add new functionality to the old operating models
    > as that does not create an incentive for people to convert their stuff
    > over.
    Thank you for your advice, but for our scenario, its effect is no
    better than this patch (because not all devices are aggressive
    devices), so we give up. :)

    And as Jason said in another thread, this problem can be solved by
    simply reducing the number of queues by ethtool. So let's ignore this
    patch since it is not acceptable.

    Huacai
    >
    > >> So the irqdomain can tell the PCI/MSI core the maximum number of vectors
    > >> available for a particular bus, right?
    > >>
    > >> The default, i.e if the irqdomain does not expose that information,
    > >> would be "unlimited", i.e. ULONG_MAX.
    > > OK, thanks, but how to expose? By msi_domain_info::hwsize?
    >
    > Probably. Needs a proper helper around it.
    >
    > Thanks,
    >
    > tglx

    \
     
     \ /
      Last update: 2023-06-01 17:20    [W:2.942 / U:0.276 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site