lkml.org 
[lkml]   [2023]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 2/5] perf: arm_cspmu: Support shared interrupts
From
On 2023-06-01 04:01, Ilkka Koskinen wrote:
> Some of the PMUs may share the interrupt. Support them by
> setting IRQF_SHARED

This has the usual problem of allowing any PMU instance to move the IRQ
affinity to a different CPU without also migrating all the other PMU
contexts, and thus breaking perf core's assumptions of mutual exclusion.

Thanks,
Robin.

> Signed-off-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>
> ---
> drivers/perf/arm_cspmu/arm_cspmu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/perf/arm_cspmu/arm_cspmu.c b/drivers/perf/arm_cspmu/arm_cspmu.c
> index 88547a2b73e6..cc5204d1b5fb 100644
> --- a/drivers/perf/arm_cspmu/arm_cspmu.c
> +++ b/drivers/perf/arm_cspmu/arm_cspmu.c
> @@ -1067,8 +1067,8 @@ static int arm_cspmu_request_irq(struct arm_cspmu *cspmu)
> return irq;
>
> ret = devm_request_irq(dev, irq, arm_cspmu_handle_irq,
> - IRQF_NOBALANCING | IRQF_NO_THREAD, dev_name(dev),
> - cspmu);
> + IRQF_NOBALANCING | IRQF_NO_THREAD | IRQF_SHARED,
> + dev_name(dev), cspmu);
> if (ret) {
> dev_err(dev, "Could not request IRQ %d\n", irq);
> return ret;

\
 
 \ /
  Last update: 2023-06-01 16:55    [W:0.392 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site