lkml.org 
[lkml]   [2023]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH V2 2/6] clk: qcom: Update l value configuration for lucid ole and evo plls
From
Hi Bryan,

Thanks for your review!

On 5/26/2023 6:52 PM, Bryan O'Donoghue wrote:
> On 25/05/2023 18:21, Jagadeesh Kona wrote:
>> -    .config_ctl_hi1_val = 0x32AA299C,
>> +    .config_ctl_hi1_val = 0x32aa299c,
>
> You should separate out this change from this patch.
>
> There's nothing wrong with having a preliminary patch to change all
> upper-case HEX to lowercase hex.
>
> You should do that since the log here "update l value" != change UCASE
> to lcase hex.
>
Sure, will remove this in the next series.
> ---
> 0xb0d

Thanks & Regards,
Jagadeesh

\
 
 \ /
  Last update: 2023-06-01 16:21    [W:0.100 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site