Messages in this thread | | | Date | Thu, 1 Jun 2023 11:41:15 +0100 | From | Jonathan Cameron <> | Subject | Re: [PATCH v4 03/23] cxl: Rename member @dport of struct cxl_dport to @dev |
| |
On Tue, 23 May 2023 18:21:54 -0500 Terry Bowman <terry.bowman@amd.com> wrote:
> From: Robert Richter <rrichter@amd.com> > > Reading code like dport->dport does not immediately suggest that this > points to the corresponding device structure of the dport. Rename > struct member @dport to @dev. > > While at it, also rename @new argument of add_dport() to @dport. This > better describes the variable as a dport (e.g. new->dport becomes to > dport->dev). > > Signed-off-by: Robert Richter <rrichter@amd.com> > Signed-off-by: Terry Bowman <terry.bowman@amd.com> LGTM. That naming confused me a few times as well.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
| |