lkml.org 
[lkml]   [2023]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 03/23] cxl: Rename member @dport of struct cxl_dport to @dev
    On Tue, 23 May 2023 18:21:54 -0500
    Terry Bowman <terry.bowman@amd.com> wrote:

    > From: Robert Richter <rrichter@amd.com>
    >
    > Reading code like dport->dport does not immediately suggest that this
    > points to the corresponding device structure of the dport. Rename
    > struct member @dport to @dev.
    >
    > While at it, also rename @new argument of add_dport() to @dport. This
    > better describes the variable as a dport (e.g. new->dport becomes to
    > dport->dev).
    >
    > Signed-off-by: Robert Richter <rrichter@amd.com>
    > Signed-off-by: Terry Bowman <terry.bowman@amd.com>
    LGTM. That naming confused me a few times as well.

    Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

    \
     
     \ /
      Last update: 2023-06-01 12:42    [W:4.341 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site