| Date | Thu, 1 Jun 2023 12:20:08 +0300 | Subject | Re: [PATCH 01/20] soc: qcom: smd-rpm: Add QCOM_SMD_RPM_STATE_NUM | From | Dmitry Baryshkov <> |
| |
On 30/05/2023 13:20, Konrad Dybcio wrote: > Add a preprocessor define to indicate the number of RPM contexts/states. > While at it, use tabs instead of spaces for the existing entries. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > include/linux/soc/qcom/smd-rpm.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/include/linux/soc/qcom/smd-rpm.h b/include/linux/soc/qcom/smd-rpm.h > index 2990f425fdef..99499e4b080e 100644 > --- a/include/linux/soc/qcom/smd-rpm.h > +++ b/include/linux/soc/qcom/smd-rpm.h > @@ -4,8 +4,9 @@ > > struct qcom_smd_rpm; > > -#define QCOM_SMD_RPM_ACTIVE_STATE 0 > -#define QCOM_SMD_RPM_SLEEP_STATE 1 > +#define QCOM_SMD_RPM_ACTIVE_STATE 0 > +#define QCOM_SMD_RPM_SLEEP_STATE 1
This is what we usually try to abstain from: ident changes + functional changes. I'd say, leave spaces as is and just add the new entry.
> +#define QCOM_SMD_RPM_STATE_NUM 2 > > /* > * Constants used for addressing resources in the RPM. >
-- With best wishes Dmitry
|