Messages in this thread | | | Date | Mon, 29 May 2023 17:21:00 +0200 | Subject | Re: [PATCH v3 1/2] gpio: tps65219: add GPIO support for TPS65219 PMIC | From | jerome Neanne <> |
| |
On 26/05/2023 20:15, andy.shevchenko@gmail.com wrote: > ... > > Missing bits.h > >> +#include <linux/gpio/driver.h> >> +#include <linux/mfd/tps65219.h> >> +#include <linux/module.h> >> +#include <linux/platform_device.h> >> +#include <linux/regmap.h> >
Thanks for your review.Just to be sure on this particular point: Your recommendation here it to include explicitly bits.h.
I can see BIT_MASK(n) defined in linux/bits.h BIT(n) is defined in vdso/bits.h From what I can see, BIT(n) is broadly used across kernel but BIT_MASK(n) sounds to be the Linux strict way...
In current version I'm using BIT(n) macro not BIT_MASK(n). Do you recommend to replace every BIT(n) currently used with BIT_MASK(n)? Sorry for asking dumb questions. Just trying to make sure I correctly/fully understand your feedback... And do it all right for the next iteration.
Regards, Jerome.
| |