Messages in this thread | | | Date | Mon, 29 May 2023 09:35:37 +0530 | Subject | Re: [PATCH v3 0/9] perf/mem: AMD IBS and generic tools improvements | From | Ravi Bangoria <> |
| |
On 16-May-23 8:15 AM, Ravi Bangoria wrote: > On 10-Apr-23 7:53 AM, Ravi Bangoria wrote: >> On 08-Apr-23 3:14 AM, Namhyung Kim wrote: >>> Hi Ravi, >>> >>> On Fri, Apr 7, 2023 at 4:25 AM Ravi Bangoria <ravi.bangoria@amd.com> wrote: >>>> >>>> Kernel IBS driver wasn't using new PERF_MEM_* APIs due to some of its >>>> limitations. Mainly: >>>> >>>> 1. mem_lvl_num doesn't allow setting multiple sources whereas old API >>>> allows it. Setting multiple data sources is useful because IBS on >>>> pre-zen4 uarch doesn't provide fine granular DataSrc details (there >>>> is only one such DataSrc(2h) though). >>>> 2. perf mem sorting logic (sort__lvl_cmp()) ignores mem_lvl_num. perf >>>> c2c (c2c_decode_stats()) does not use mem_lvl_num at all. perf mem >>>> prints mem_lvl and mem_lvl_num both if both are set, which is ugly. >>>> >>>> Set mem_lvl_num, mem_remote and mem_hops for data_src via IBS. Handle >>>> first issue using mem_lvl_num = ANY_CACHE | HOPS_0. In addition to >>>> setting new API fields, convert all individual field assignments to >>>> compile time wrapper macros built using PERF_MEM_S(). Also convert >>>> DataSrc conditional code to array lookups. >>>> >>>> Interpretation of perf_mem_data_src by perf_mem__lvl_scnprintf() was >>>> non-intuitive. Make it sane. >>> >>> Looks good, but I think you need to split kernel and user patches. >> >> Patch #1 to #3 are kernel changes. Patch #4 to #9 are userspace changes. >> Arnaldo, Peter, please let me know if you wants to split the series and >> resend. > > Hi Peter, tools/ patches are already upstream. Can you please pick up > kernel changes.
Gentle ping, Peter!
Thanks, Ravi
| |