Messages in this thread | | | Date | Tue, 30 May 2023 11:59:12 +0800 | From | Yue Hu <> | Subject | Re: [PATCH v3 5/6] erofs: use struct lockref to replace handcrafted approach |
| |
On Mon, 29 May 2023 20:37:27 +0800 Gao Xiang <hsiangkao@linux.alibaba.com> wrote:
> Let's avoid the current handcrafted lockref although `struct lockref` > inclusion usually increases extra 4 bytes with an explicit spinlock if > CONFIG_DEBUG_SPINLOCK is off. > > Apart from the size difference, note that the meaning of refcount is > also changed to active users. IOWs, it doesn't take an extra refcount > for XArray tree insertion. > > I don't observe any significant performance difference at least on > our cloud compute server but the new one indeed simplifies the > overall codebase a bit. > > Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Reviewed-by: Yue Hu <huyue2@coolpad.com>
| |