Messages in this thread | | | Date | Sun, 28 May 2023 09:52:35 +0200 | From | Willy Tarreau <> | Subject | Re: [PATCH 06/13] selftests/nolibc: allow specify a bios for qemu |
| |
On Fri, May 26, 2023 at 09:00:02AM +0200, Thomas Weißschuh wrote: > On 2023-05-25 01:52:29+0800, Zhangjin Wu wrote: > > riscv qemu has a builtin bios (opensbi), but it may not match the latest > > kernel and some old versions may hang during boot, let's allow user pass > > a newer version to qemu via the -bios option. > > Nitpick: > > This seems very specific and hopefully only necessary temporarily. > > Instead it could be changed to some generic mechanim like > "QEMU_ARGS_EXTRA"?
FWIW I, too, think that QEMU_ARGS_EXTRA could be very convenient for various test cases on any architecture (change number of CPUs, RAM size, boot options etc).
Willy
| |