Messages in this thread | | | Date | Sun, 28 May 2023 18:38:55 +0100 | From | Jonathan Cameron <> | Subject | Re: [PATCH v2 7/9] ASoC: codecs: Add support for the generic IIO auxiliary devices |
| |
On Tue, 23 May 2023 17:12:21 +0200 Herve Codina <herve.codina@bootlin.com> wrote:
> Industrial I/O devices can be present in the audio path. > These devices needs to be used as audio components in order to be fully > integrated in the audio path. > > This support allows to consider these Industrial I/O devices as auxliary > audio devices and allows to control them using mixer controls. > > Signed-off-by: Herve Codina <herve.codina@bootlin.com> > ---
> diff --git a/sound/soc/codecs/audio-iio-aux.c b/sound/soc/codecs/audio-iio-aux.c > new file mode 100644 > index 000000000000..21575c4b35fd > --- /dev/null > +++ b/sound/soc/codecs/audio-iio-aux.c > @@ -0,0 +1,302 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +// > +// audio-iio-aux.c -- ALSA SoC glue to use IIO devices as audio components > +// > +// Copyright 2023 CS GROUP France > +// > +// Author: Herve Codina <herve.codina@bootlin.com> > + > +#include <linux/iio/consumer.h> > +#include <linux/module.h>
#include <linux/mod_devicetable.h> ideally to pick up the of_device_id definition without bouncing through some non obvious header path.
> +#include <linux/slab.h> > +#include <sound/soc.h> > +#include <sound/tlv.h>
Otherwise, the IIO elements of this look good. So for those at least Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
I don't have enough knowledge of the snd stuff to review those parts.
Jonathan
| |