lkml.org 
[lkml]   [2023]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 3/6] clk: qcom: Add lpass clock controller driver for SC8280XP
    On Thu, May 25, 2023 at 01:29:27PM +0100, Srinivas Kandagatla wrote:
    > Add support for the lpass clock controller found on SC8280XP based devices.
    > This would allow lpass peripheral loader drivers to control the clocks and
    > bring the subsystems out of reset.
    >
    > Currently this patch only supports resets as the Q6DSP is in control of
    > LPASS IP which manages most of the clocks via Q6PRM service on GPR rpmsg
    > channel.
    >
    > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
    > ---
    > drivers/clk/qcom/Kconfig | 8 ++++
    > drivers/clk/qcom/Makefile | 1 +
    > drivers/clk/qcom/lpasscc-sc8280xp.c | 63 +++++++++++++++++++++++++++++
    > 3 files changed, 72 insertions(+)
    > create mode 100644 drivers/clk/qcom/lpasscc-sc8280xp.c

    > --- /dev/null
    > +++ b/drivers/clk/qcom/lpasscc-sc8280xp.c
    > @@ -0,0 +1,63 @@
    > +// SPDX-License-Identifier: GPL-2.0-only
    > +/*
    > + * Copyright (c) 2022, Linaro Limited
    > + */
    > +
    > +#include <linux/clk-provider.h>
    > +#include <linux/err.h>
    > +#include <linux/kernel.h>
    > +#include <linux/module.h>
    > +#include <linux/of_device.h>
    > +#include <linux/regmap.h>

    Newline?

    > +#include <dt-bindings/clock/qcom,lpasscc-sc8280xp.h>
    > +
    > +#include "common.h"
    > +#include "reset.h"
    > +
    > +static const struct qcom_reset_map lpasscc_sc8280xp_resets[] = {
    > + [LPASS_AUDIO_SWR_TX_CGCR] = { 0xc010, 1 },
    > +};
    > +
    > +static struct regmap_config lpasscc_sc8280xp_regmap_config = {
    > + .reg_bits = 32,
    > + .reg_stride = 4,
    > + .val_bits = 32,
    > + .name = "lpass-tcsr",
    > + .max_register = 0x12000,
    > +};
    > +
    > +static const struct qcom_cc_desc lpasscc_reset_sc8280xp_desc = {

    Nit: Isn't "lpasscc_sc8280xp" the prefix you should use throughout
    (i.e. this should be lpasscc_sc8280xp_reset_desc or similar).

    > + .config = &lpasscc_sc8280xp_regmap_config,
    > + .resets = lpasscc_sc8280xp_resets,
    > + .num_resets = ARRAY_SIZE(lpasscc_sc8280xp_resets),
    > +};
    > +
    > +static const struct of_device_id lpasscc_sc8280xp_match_table[] = {
    > + {
    > + .compatible = "qcom,sc8280xp-lpasscc",
    > + .data = &lpasscc_reset_sc8280xp_desc,
    > + },
    > + { }
    > +};
    > +MODULE_DEVICE_TABLE(of, lpasscc_sc8280xp_match_table);

    Looks good otherwise:

    Reviewed-by: Johan Hovold <johan+linaro@kernel.org>

    \
     
     \ /
      Last update: 2023-05-26 14:12    [W:4.147 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site