lkml.org 
[lkml]   [2023]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] smsdvb-debugfs.c: Fix error checking for debugfs_create_file
Em Wed, 24 May 2023 21:42:10 +0500
Osama Muhammad <osmtendev@gmail.com> escreveu:

> This patch fixes the error checking in smsdvb-debugfs.c in
> debugfs_create_file. The correct way to check if an error occurred
> is using 'IS_ERR_OR_NULL' inline function.
>
> Signed-off-by: Osama Muhammad <osmtendev@gmail.com>
> ---
> drivers/media/common/siano/smsdvb-debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/common/siano/smsdvb-debugfs.c b/drivers/media/common/siano/smsdvb-debugfs.c
> index 8916bb644756..0f8750d7993c 100644
> --- a/drivers/media/common/siano/smsdvb-debugfs.c
> +++ b/drivers/media/common/siano/smsdvb-debugfs.c
> @@ -469,7 +469,7 @@ int smsdvb_debugfs_create(struct smsdvb_client_t *client)
>
> d = debugfs_create_file("stats", S_IRUGO | S_IWUSR, client->debugfs,
> client, &debugfs_stats_ops);
> - if (!d) {
> + if (IS_ERR_OR_NULL(d)) {
> debugfs_remove(client->debugfs);
> return -ENOMEM;

if IS_ERR, it is probably better to return PTR_ERR(d).

So, please change it accordingly, returning -ENOMEM only on NULL, e. g.
something like (untested):

if (IS_ERR_OR_NULL(d)) {
debugfs_remove(client->debugfs);
if (!d)
return -ENOMEM;
return PTR_ERR(d);
}

Regards,
Mauro

\
 
 \ /
  Last update: 2023-05-26 12:54    [W:0.052 / U:0.848 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site